server: remove duplicate top_logprobs validation#14564
Open
umut-polat wants to merge 1 commit intoollama:mainfrom
Open
server: remove duplicate top_logprobs validation#14564umut-polat wants to merge 1 commit intoollama:mainfrom
umut-polat wants to merge 1 commit intoollama:mainfrom
Conversation
Both GenerateHandler and ChatHandler validated top_logprobs twice: once early after parsing the request and again after loading the model. The second check is unreachable since the first already returns on invalid values. Signed-off-by: umut-polat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both GenerateHandler and ChatHandler validated
top_logprobstwice: once early after parsing the request and again after loading the model. The second check is unreachable dead code since the first already returns on invalid values.Removed the duplicate checks at lines 236 and 2038 (before this change).