server: add model name validation and alias resolution to EmbedHandler#14565
Open
umut-polat wants to merge 1 commit intoollama:mainfrom
Open
server: add model name validation and alias resolution to EmbedHandler#14565umut-polat wants to merge 1 commit intoollama:mainfrom
umut-polat wants to merge 1 commit intoollama:mainfrom
Conversation
EmbedHandler was missing the model name validation (IsValid check) and alias resolution that GenerateHandler and ChatHandler both perform. This meant an empty model name produced a confusing "model not found" error instead of "model is required", and model aliases were not resolved for embed requests. Signed-off-by: umut-polat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbedHandler was missing two steps that both GenerateHandler and ChatHandler perform:
Model name validation (
name.IsValid()check) — an empty or invalid model name went straight togetExistingName, producing a confusing "model not found" error instead of the expected "model is required".Alias resolution (
resolveAlias) — model aliases were silently ignored for/api/embedrequests while working correctly for/api/generateand/api/chat.This aligns EmbedHandler's validation flow with the other handlers.