Add LTCG linker flag for optimization #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil R. Spruit <[email protected]>
8eaef76 to
42127a7
Compare
leonardo-intel
approved these changes
Apr 1, 2025
leonardo-intel
suggested changes
Apr 1, 2025
There was a problem hiding this comment.
This morning we had a meeting regarding this flag and it was discussed that setting /LTCG:incremental disables whole program optimization. Also, the binskim output recommends to use /LTCG along with WholeProgramOptimization (/GL).
C:\Users\callumso\dev\npu-driver\build\x64\level_zero\src\level_zero-build\bin\Release\ze_loader.dll: warning BA6006: 'ze_loader.dll' was compiled without Link Time Code Generation (/LTCG). Enabling LTCG can improve optimizations and performance.
For VC projects use WholeProgramOptimization property with 'true' value.
so can you update the PR to not set LTCG with incremental linking, and to also enable WholeProgramOptimization
So the linker flags should be:
/LTCG
/GL
Signed-off-by: Neil R. Spruit <[email protected]>
leonardo-intel
approved these changes
Apr 1, 2025
Signed-off-by: Neil R. Spruit <[email protected]>
rwmcguir
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.