incorrect "commonFolder" values in two FPGA samples #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
We are retiring the MRAA/UPM IoT samples.
field for the FPGA "compute_units" and "pipe_array" samples. This fixes a problem in the sample.json files for these two samples. These mistakes cannot be found by the sample.json schema checker, so a check for this condition was added to the sample aggregator's code. The new test confirms that the files referenced by the commonFolder object do exist.
tingleby
approved these changes
May 3, 2022
praveenkk123
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Incorrect number of "../../.." relative references in the commonFolder field for the FPGA "compute_units" and "pipe_array" samples.
This fixes a problem in the sample.json files for these two samples. These mistakes cannot be found by the sample.json schema checker, so a check for this condition was added to the sample aggregator's code. The new test confirms that the files referenced by the commonFolder object do exist.
External Dependencies
The 2022.1 tag should also be corrected, since this error has been causing problems with the samples for some time.
Type of change
How Has This Been Tested?
Command-line testing of the aggregator and also testing in staging to confirm that all samples are being properly processed.
FYI: @praveenkk123