Handle generated asset symbols via member access scanning #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `generatedAssetSymbolKey` extension to `String` to convert resource names into Swift asset symbols. Update `unusedFiles` to detect asset usage through member access patterns in Swift code. Add `SwiftMemberAccessSearchRule` to match asset symbols like `.icFlag` or `UIImage.icFlag`. Include tests for new functionality using fixture files.
Introduce test cases for the SwiftMemberAccessSearchRule to ensure it correctly processes generated symbols and ignores regular property access. This enhancement improves test coverage and validates that the search rule correctly identifies image-related symbols within Swift code, particularly those that rely on member access patterns.
…sset-member-access-add-test Update test case for generated asset symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to #83 and @duckSern1108 for surfacing the problem—I prefer solving it with this PR so we address the reported issue without changing the API surface.
Testing
swift test