StreamWriterBuilder #132
Merged
StreamWriterBuilder #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08b3760 to
e3f2428
Compare
e41ae7e to
c417807
Compare
also, use withers instead of setters, and update docs
cdunn2001
added a commit
that referenced
this pull request
Jan 26, 2015
StreamWriter::Builder Deprecate old Writers, but include them in tests. This should still be binary-compatible with 1.3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we use a Builder to configure a StreamWriter more easily.
We use virtual methods to hide the implementation. But we use a concrete wrapper to hide the virtual methods. This allows us to add new methods without bumping the major version, maintaining binary-compatibility.
I plan to fix #103 using this new API, but for now
operator<<()is functionally unchanged.We still need a plan for
FastWriter.See #131.