[BUILD] Fix -Wmissing-template-arg-list-after-template-kw warning #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3133 +/- ##
==========================================
+ Coverage 87.12% 87.85% +0.73%
==========================================
Files 200 195 -5
Lines 6109 6136 +27
==========================================
+ Hits 5322 5390 +68
+ Misses 787 746 -41
|
lalitb
approved these changes
Nov 7, 2024
ThomsonTan
approved these changes
Nov 7, 2024
zanmato1984
added a commit
to apache/arrow
that referenced
this pull request
Jun 2, 2025
…ent Clang (#46509) ### Rationale for this change A warning is introduced in Clang 19.1.0 and AppleClang 17.0.0 that won't be demoted by `-Wno-error`, causing opentelemetry-cpp build failure. ### What changes are included in this PR? Upgrade opentelemetry-cpp (and opentelemetry-proto correspondingly) to the most recent version, which has addressed this issue in open-telemetry/opentelemetry-cpp#3133. With this upgrade, we found several false-positives in sanitizers. The reason seems to be that we build bundled third-party dependencies as static libraries and don't instrument their code. This is known to cause false-positives as per https://github.com/google/sanitizers/wiki/threadsanitizercppmanual#non-instrumented-code . So some suppressions and disablements are also made in this PR. ### Are these changes tested? Manually build pass. ### Are there any user-facing changes? None. * GitHub Issue: #46508 Authored-by: Rossi Sun <[email protected]> Signed-off-by: Rossi Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3124
Changes
Fix for
missing-template-arg-list-after-template-kwwarning.