Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SDK] Fix BatchLogRecordProcessor to instrument shutdown #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Feb 4, 2025

Fixes #3261

Changes

Please provide a brief description of the changes here.

  • In BatchLogRecordProcessor, used the same coding pattern in BatchSpanProcessor, so that proper OnEnd() instrumentation is called on shutdown.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 75570bb
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67a1ebbb17ca7e0008fb0eca

@marcalff marcalff marked this pull request as ready for review February 4, 2025 10:29
@marcalff marcalff requested a review from a team as a code owner February 4, 2025 10:29
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (edb8937) to head (75570bb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3262      +/-   ##
==========================================
+ Coverage   87.91%   87.92%   +0.01%     
==========================================
  Files         201      201              
  Lines        6385     6386       +1     
==========================================
+ Hits         5613     5614       +1     
  Misses        772      772              
Files with missing lines Coverage Δ
sdk/src/logs/batch_log_record_processor.cc 83.01% <100.00%> (+0.12%) ⬆️

@marcalff marcalff changed the title Fix BatchLogRecordProcessor to instrument shutdown [SDK] Fix BatchLogRecordProcessor to instrument shutdown Feb 4, 2025
@marcalff marcalff merged commit 3506a7a into open-telemetry:main Feb 4, 2025
57 checks passed
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this pull request Feb 4, 2025
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Feb 4, 2025
[SDK] Fix BatchLogRecordProcessor to instrument shutdown (open-telemetry#3262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] BatchLogRecordProcessor is not calling thread instrumentation on shutdown
2 participants