-
Notifications
You must be signed in to change notification settings - Fork 483
[CI] OTLP in Windows builds #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] OTLP in Windows builds #3263
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
b9948e3
to
db8c018
Compare
Thanks for the PR.
Wondering if the delay is from the PR (gRPC build), or the CI env itself is slow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Installing grpc might take some time; alternatively, could it be included in the dev image? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Looks like I missed this comment before hitting the merge button. To address separately then, decide if/how to use default grpc, curl, etc packages on each platform, instead of building from source. |
[CI] OTLP in Windows builds (open-telemetry#3263)
Fixes #3253
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes