[BUILD] Enable old behavior of CMP0092 #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 205 205
Lines 6407 6407
=======================================
Hits 5635 5635
Misses 772 772 |
owent
approved these changes
Feb 21, 2025
marcalff
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on below doc, CMake 3.15 introduced policy CMP0092 which removes
/W3option by default for MSVC. This change restores the old behavior of CMP0092 to keep/W3for MSVC, before we set the warning level explicitly for the project.CMakeLists
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes