Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUILD] Add link directory to support curl 8.12 #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

owent
Copy link
Member

@owent owent commented Feb 13, 2025

Add link directory to support curl 8.12

Fixes #3271

Changes

Certain versions of libcurl link dependency libraries from the package manager's installation directory but don't expose the link directories. This patch resolves this issue and also corrects the target name of libcurl in the official build script.

  • Link directory of libcurl to find dependencies of libcurl 8.12.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner February 13, 2025 11:08
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e44f195
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67bd8f5728974f0008e001e6

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (3c4afd0) to head (e44f195).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3272   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files         207      207           
  Lines        6457     6457           
=======================================
  Hits         5773     5773           
  Misses        684      684           

@lalitb lalitb self-assigned this Feb 19, 2025
Add link directory to support curl 8.12

Fix style
@marcalff marcalff changed the title Add link directory to support curl 8.12 [BUILD] Add link directory to support curl 8.12 Feb 24, 2025
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 5, 2025
@marcalff marcalff merged commit edfeabe into open-telemetry:main Mar 5, 2025
58 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Mar 5, 2025
Add link directory to support curl 8.12 (open-telemetry#3272)
@owent owent deleted the fixex_3271 branch March 7, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build with curl 8.12
3 participants