Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[EXPORTER] Support exporting event_name using OTLP Exporter #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2025
Merged

[EXPORTER] Support exporting event_name using OTLP Exporter #3277

merged 2 commits into from
Feb 16, 2025

Conversation

perhapsmaple
Copy link
Contributor

Fixes #3201

Changes

OtlpLogRecordable now supports exporting EventId::name

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@perhapsmaple perhapsmaple requested a review from a team as a code owner February 16, 2025 08:27
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ccd1a3d
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67b1a18482261b00082c0663

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (2fdc022) to head (ccd1a3d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3277   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772

@marcalff marcalff changed the title Support exporting event_name using OTLP Exporter [EXPORTER] Support exporting event_name using OTLP Exporter Feb 16, 2025
marcalff
marcalff approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 7f047d5 into open-telemetry:main Feb 16, 2025
57 checks passed
@perhapsmaple perhapsmaple deleted the otlp-log-event-name branch February 16, 2025 11:05
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support exporting event_name using OTLP Exporter
3 participants
@perhapsmaple @lalitb @marcalff