Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUILD] Fix compiling problems with abiv2 and MSVC #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

owent
Copy link
Member

@owent owent commented Feb 21, 2025

Fixes #3283

Changes

  • Fix tracer implementation in ETW exporter with abiv2

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner February 21, 2025 06:45
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 505ff6e
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67b820f72288a8000891fc8e

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (cd7103e) to head (505ff6e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3284   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @owent.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Fix compiling problems with abiv2 and MSVC [BUILD] Fix compiling problems with abiv2 and MSVC Feb 21, 2025
@marcalff marcalff merged commit 181f1e5 into open-telemetry:main Feb 21, 2025
58 checks passed
@owent owent deleted the fix_compiling_with_abiv2_msvc branch February 25, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build on Windows with ABI v2 and ETW exporter
3 participants