-
Notifications
You must be signed in to change notification settings - Fork 483
[API] Deprecate event logger #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 207 207
Lines 6457 6457
=======================================
Hits 5773 5773
Misses 684 684
|
37f6452
to
7c97425
Compare
@owent thanks for the PR. The event logger related changes look good in general. However, can we move the clang formatting related changes out of scope of this PR? we can have separate PR for that if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change contains two independent parts:
- deprecation (abi v1) and removal (abi v2) of the event logger
- clang-format changes with compiler attributes macros
Approving this PR because both look ok.
See comments on vscode file.
@owent For future work, please separate independent changes in different PRs.
This helps with the git history, and helps when a backport is needed to an older branch for some fixes.
Waiting on clarifications and/or cleanup for vscode file, before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
0ab2698
to
8066432
Compare
@lalitb @marcalff The format changes are included into this PR because there will be strange format style in some files of log's codes. They may cause some confuse. |
Fixes #3193
Changes
.clang-format
to fix some format error on Windows.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes