[API] Change the param-pack unpacking order to start from left to right #3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
lalitb
reviewed
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3296 +/- ##
==========================================
+ Coverage 89.41% 89.41% +0.01%
==========================================
Files 207 207
Lines 6457 6458 +1
==========================================
+ Hits 5773 5774 +1
Misses 684 684
🚀 New features to boost your workflow:
|
lalitb
approved these changes
Mar 11, 2025
owent
approved these changes
Mar 11, 2025
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The parameter pack sent to
EmitLogRecordis unpacked from right to left, which are caused by passing them as function parameters to template functionIgnoreTraitResult. This will send the rightmostattributesparameter to the processor and then pass it to theRecordable. It makes it a little hard to do serialization in theRecordableinterface, because the serialization usually needs to encode the data like event name or severity before encoding the attributes.This PR changes the unpack order to help do serialization in the
Recordableinterface in a straightforward way, without caching any attributes.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes