Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SDK] Use OPENTELEMETRY_EXPORT and static local variables #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2025
Merged

[SDK] Use OPENTELEMETRY_EXPORT and static local variables #3314

merged 6 commits into from
Mar 24, 2025

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Mar 22, 2025

Fixes #3302

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Mar 22, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 3894904
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67e13dc43b655c0008176737

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (4af490f) to head (3894904).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3314      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.03%     
==========================================
  Files         210      210              
  Lines        6522     6526       +4     
==========================================
+ Hits         5837     5842       +5     
+ Misses        685      684       -1
Files with missing lines Coverage Δ
...k/include/opentelemetry/sdk/metrics/meter_config.h 100.00% <ø> (ø)
...dk/include/opentelemetry/sdk/trace/tracer_config.h 100.00% <ø> (ø)
sdk/src/metrics/meter_config.cc 100.00% <100.00%> (ø)
sdk/src/trace/tracer_config.cc 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psx95 psx95 marked this pull request as ready for review March 23, 2025 21:17
@psx95 psx95 requested a review from a team as a code owner March 23, 2025 21:17
owent
owent approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we can also export copy constructors and copy assignment operators to reduce dumplicated weak symbols.

@marcalff
Copy link
Member

@psx95 We would like to invite you to become an opentelemetry-cpp approver, if you would like to become one.

To do so, please file a PR similar to this one:

@marcalff marcalff merged commit 0fa41f9 into open-telemetry:main Mar 24, 2025
58 checks passed
@psx95
Copy link
Contributor Author

psx95 commented Mar 25, 2025

@psx95 We would like to invite you to become an opentelemetry-cpp approver, if you would like to become one.

To do so, please file a PR similar to this one:

Thanks Marc, I'd be happy to ! 😄

@psx95 psx95 mentioned this pull request Mar 25, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use OPENTELEMETRY_EXPORT for functions in meter_config & tracer_config
3 participants
@psx95 @marcalff @owent