Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TEST] fix segfault in singleton test with cmake on macos-latest #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

dbarker
Copy link
Contributor

@dbarker dbarker commented Mar 22, 2025

Fixes #3315

Changes

  • add conditional to load the .dylib shared library files on macos in the singleton test

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner March 22, 2025 22:12
Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit b2a5ffc
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67df35d055ab9f00080452fa

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (b4328c0) to head (b2a5ffc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3316   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         210      210           
  Lines        6522     6522           
=======================================
  Hits         5838     5838           
  Misses        684      684           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 2c9b68f into open-telemetry:main Mar 23, 2025
58 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Mar 23, 2025
[TEST] load the .dylib files on macos in the singleton test (open-telemetry#3316)
@dbarker dbarker deleted the fix_singleton_test_on_macos branch March 31, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SingletonTest.Uniqueness SEGFAULT with cmake build on macos-latest
2 participants