Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DEVCONTAINER] expose cmake version setting as docker arg and environment variable #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2025
Merged

[DEVCONTAINER] expose cmake version setting as docker arg and environment variable #3347

merged 2 commits into from
Apr 6, 2025

Conversation

dbarker
Copy link
Contributor

@dbarker dbarker commented Apr 4, 2025

Support testing with specific cmake versions locally in the devcontainer.

docker build --build-arg CMAKE_VERSION=4.0.0 --build-arg USER_UID="$(id -u)" --build-arg USER_GID="$(id -g)" -t opentelemetry-cpp-dev:latest_cmake -f ./.devcontainer/Dockerfile.dev .

Changes

  • Adds a docker arg for CMAKE_VERSION
  • Adds an environment variable for OTEL_CPP_DEVCONTAINER_CMAKE_VERSION
  • Updates the devcontainer readme

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner April 4, 2025 18:42
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit f6719b5
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67f027fc86d4b8000808e601

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (4a0d19f) to head (f6719b5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
+ Coverage   89.55%   89.56%   +0.02%     
==========================================
  Files         210      210              
  Lines        6502     6502              
==========================================
+ Hits         5822     5823       +1     
+ Misses        680      679       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

marcalff
marcalff approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the feature

@marcalff marcalff merged commit b6908f0 into open-telemetry:main Apr 6, 2025
66 checks passed
@malkia malkia mentioned this pull request Apr 6, 2025
Merged
3 tasks
@dbarker dbarker deleted the feature_add_cmake_version_to_devcontainer branch April 19, 2025 00:43
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbarker @marcalff