[EXPORTER] support unix sockets in grpc client #3410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 212 212
Lines 6941 6941
=======================================
Hits 6238 6238
Misses 703 703 🚀 New features to boost your workflow:
|
owent
reviewed
May 15, 2025
| std::string grpc_target = url.host_ + ":" + std::to_string(static_cast<int>(url.port_)); | ||
| std::string grpc_target; | ||
|
|
||
| if (url.scheme_ == "unix") |
There was a problem hiding this comment.
Could you please add a test for unix socket?
There was a problem hiding this comment.
Also add some example on the unix scheme in the comment to help understanding?
ThomsonTan
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3411
Changes
Replaces the construction of the gRPC target for the otlp grpc client to support unix sockets.