Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DOCS] update the INSTALL guide on cmake components #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dbarker
Copy link
Contributor

@dbarker dbarker commented May 16, 2025

Fixes #3408

Changes

  • reference the opentelemetry-cpp::trace target instead of the interface only opentelemetry-cpp::sdk target
  • add a note about the etw and elasticsearch components potential to be moved out of the core package

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

…terface sdk target and add note about potential move of the etw and elasticsearch components
Copy link

netlify bot commented May 16, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit b03235c
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68278d8321071c000882a9a5

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (0f8dedf) to head (b03235c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   90.01%   90.04%   +0.03%     
==========================================
  Files         212      212              
  Lines        6932     6932              
==========================================
+ Hits         6239     6241       +2     
+ Misses        693      691       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review May 16, 2025 22:28
@dbarker dbarker requested a review from a team as a code owner May 16, 2025 22:28
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@lalitb lalitb merged commit b7e7333 into open-telemetry:main May 17, 2025
67 checks passed
@dbarker dbarker deleted the docs_update_install_doc_components_table branch May 20, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note to INSTALL guide about components that may move to opentelemetry-cpp-contrib
3 participants