Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CMAKE] Remove third-party version mismatch warning #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dbarker
Copy link
Contributor

@dbarker dbarker commented May 21, 2025

This is a new warning added but is unreliable when building and installing opentelemetry-cpp against third party submodules or external clones. In those cases determining the dependency version is not reliable or implemented in all cases.

This check can be revisited in the future.

Changes

  • remove the warning

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented May 21, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 08dd7c5
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6830a594faca6b00085b9c33

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (87c216f) to head (08dd7c5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3432   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         212      212           
  Lines        6941     6941           
=======================================
  Hits         6238     6238           
  Misses        703      703           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review May 21, 2025 19:18
@dbarker dbarker requested a review from a team as a code owner May 21, 2025 19:18
@ThomsonTan
Copy link
Contributor

Is there any known issue on these we only have a few dependencies?

@marcalff marcalff changed the title [CMAKE] Remove third-party version mismatch warning for now [CMAKE] Remove third-party version mismatch warning May 23, 2025
@dbarker
Copy link
Contributor Author

dbarker commented May 23, 2025

Is there any known issue on these we only have a few dependencies?

The dependencies that may be included as submodules or src and built in-tree (add_subdirectory) won't populate the CMake <package>_VERSION variable (which is populated when the dependency is found with find_package). Those include nlohmann-json, opentracing-cpp, and prometheus-cpp. In at least one case (vcpkg package used by ci of prometheus-cpp) the find_package call doesn't populate the <package>_VERSION variable.

Since there are testing gaps in ci for all the options to include a third party dependency supported by otel-cpp cmake, it is better to remove this version check warning for now and reevaluate a check like this once tests can be added.

@ThomsonTan
Copy link
Contributor

Is there any known issue on these we only have a few dependencies?

The dependencies that may be included as submodules or src and built in-tree (add_subdirectory) won't populate the CMake <package>_VERSION variable (which is populated when the dependency is found with find_package). Those include nlohmann-json, opentracing-cpp, and prometheus-cpp. In at least one case (vcpkg package used by ci of prometheus-cpp) the find_package call doesn't populate the <package>_VERSION variable.

Since there are testing gaps in ci for all the options to include a third party dependency supported by otel-cpp cmake, it is better to remove this version check warning for now and reevaluate a check like this once tests can be added.

Thanks for sharing the details. Could we file an issue to track the revisiting of the issue?

@marcalff marcalff merged commit 7a9c609 into open-telemetry:main May 24, 2025
67 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 24, 2025
[CMAKE] Remove third-party version mismatch warning (open-telemetry#3432)
@dbarker dbarker deleted the fix_remove_thirdparty_version_warning branch May 31, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants