-
Notifications
You must be signed in to change notification settings - Fork 483
[CMAKE] Remove third-party version mismatch warning #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMAKE] Remove third-party version mismatch warning #3432
Conversation
…odules is not yet reliable
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 212 212
Lines 6941 6941
=======================================
Hits 6238 6238
Misses 703 703 🚀 New features to boost your workflow:
|
Is there any known issue on these we only have a few dependencies? |
The dependencies that may be included as submodules or src and built in-tree (add_subdirectory) won't populate the CMake Since there are testing gaps in ci for all the options to include a third party dependency supported by otel-cpp cmake, it is better to remove this version check warning for now and reevaluate a check like this once tests can be added. |
Thanks for sharing the details. Could we file an issue to track the revisiting of the issue? |
[CMAKE] Remove third-party version mismatch warning (open-telemetry#3432)
This is a new warning added but is unreliable when building and installing opentelemetry-cpp against third party submodules or external clones. In those cases determining the dependency version is not reliable or implemented in all cases.
This check can be revisited in the future.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes