Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUILD] Add missing CMake keyword for target_link_libraries #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

[BUILD] Add missing CMake keyword for target_link_libraries #3442

merged 1 commit into from
May 23, 2025

Conversation

ThomsonTan
Copy link
Contributor

Since the same target was linked with PRIVATE keyboard (see below), it should have explicit keyword for all the dependencies. Or there will be CMake error like the following.

  target_link_libraries(
    example_otlp_instrumented_http PRIVATE common_metrics_foo_library

CMake Error at examples/otlp/CMakeLists.txt:117 (target_link_libraries):
The keyword signature for target_link_libraries has already been used with
the target "example_otlp_instrumented_http". All uses of
target_link_libraries with a target must be either all-keyword or
all-plain.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team as a code owner May 23, 2025 14:38
@netlify Netlify
Copy link

netlify bot commented May 23, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit c70f14a
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68308873d550180008246300

@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (c2ea734) to head (c70f14a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.02%     
==========================================
  Files         212      212              
  Lines        6941     6941              
==========================================
+ Hits         6237     6238       +1     
+ Misses        704      703       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff merged commit 87c216f into open-telemetry:main May 23, 2025
67 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 23, 2025
@malkia
Merge pull request #306 from open-telemetry/main
3b757db 
[CMake] Add missing CMake keyword for target_link_libraries (open-telemetry#3442)
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarker dbarker dbarker approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomsonTan @dbarker @marcalff