ClickHouse client v0.8 instrumentation #14501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
reviewed
Aug 22, 2025
instrumentation/clickhouse/clickhouse-client-0.8/javaagent/build.gradle.kts
Show resolved
Hide resolved
...o/opentelemetry/javaagent/instrumentation/clickhouse/v0_8/ClickHouseClientV2QueryAdvice.java
Outdated
Show resolved
Hide resolved
instrumentation/clickhouse/clickhouse-client-common/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/clickhouse/common/ClickHouseAttributesGetter.java
Show resolved
Hide resolved
laurit
reviewed
Aug 25, 2025
...javaagent/instrumentation/clickhouse/client/v0_5/ClickHouseClientV1ExecuteAndWaitAdvice.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/clickhouse/common/ClickHouseNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/clickhouse/clientv2/v0_8/ClickHouseClientV2QueryAdvice.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/javaagent/instrumentation/clickhouse/client/v0_5/ClickHouseClientV1Test.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Aug 27, 2025
jaydeluca
reviewed
Aug 27, 2025
instrumentation/clickhouse/clickhouse-clientv2-0.8/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
…uild.gradle.kts Co-authored-by: Jay DeLuca <[email protected]>
laurit
approved these changes
Sep 2, 2025
jaydeluca
reviewed
Sep 5, 2025
| val testStableSemconv by registering(Test::class) { | ||
| jvmArgs("-Dotel.semconv-stability.opt-in=database") | ||
|
|
||
| systemProperty("metaDataConfig", "otel.semconv-stability.opt-in=database") |
There was a problem hiding this comment.
this casing changed recently
Suggested change
| systemProperty("metaDataConfig", "otel.semconv-stability.opt-in=database") | |
| systemProperty("metadataConfig", "otel.semconv-stability.opt-in=database") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since many variables in
Clientclass are private, it wasn’t possible to extract the exact insert query from theinsertmethod todb.statement, so I did not implementinputmethod tracing.Since ClickHouse Java Client 0.8, the V2 interface seems to have stabilized, so I assumed support beginning with 0.8.
For the V1, tracing can still be achieved through the existing ClickHouse instrumentation.
resolve #14364