test(configuration): refactor tests for env- and file-based config to separate files#6759
Open
trentm wants to merge 2 commits into
Open
test(configuration): refactor tests for env- and file-based config to separate files#6759trentm wants to merge 2 commits into
trentm wants to merge 2 commits into
Conversation
… separate files ConfigFactory.test.ts was >2500 lines, which was making maint a little labourious. No functional change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6759 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 377 377
Lines 12743 12743
Branches 2896 2896
=======================================
Hits 12100 12100
Misses 643 643 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigFactory.test.ts was >2500 lines, which was making maint a little labourious.
No functional change.
Definitely ignore whitespace when looking at the diff. I removed one nested
describe(...so most code is dedented by 2 spaces.