Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle log_event() and log() on the OT shim #240

Closed
@johananl

Description

@johananl

The log_event() and log() methods on opentracing.Span are deprecated and are now implemented using log_kv(). We should do one of the following:

  • Verify the two methods work as expected when called on an OT shim instance.
  • Decide to drop support for them, note this fact in the documentation and perhaps log a warning in case they are called.

There is a good chance they simply work as-is since the OT shim implements the log_kv() method.

# TODO: Verify calls to deprecated methods `log_event()` and `log()` on
# base class work properly (it's probably fine because both methods call
# `log_kv()`).

Metadata

Metadata

Assignees

No one assigned

    Labels

    shimOpenTracing or OpenCensus compatibilitytracing

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions