Tag more reviewers #102
Merged
Tag more reviewers #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-feld @lzchen @toumorokoshi need your explicit approval. |
carlosalberto
approved these changes
Aug 22, 2019
Oberon00
approved these changes
Aug 22, 2019
|
BTW, I think some more people should get write-access to the SIG notes Google doc too. Looks like anyone who already has access to the doc and knows their GMail addresses (or whatever they use to edit the doc) should be able to add them. |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…#102) * Add Real Span * Fix review comments - Log a warning when span is already ended. - Validate spancontext - Add serialization logic for setAttribute - Add spancontext-utils * Fix review comments, fix build, add span tests * Fix review comments - Create SpanContext in constructor once - Rename _getSpanContext to _getParentSpanContext - Rename underscore prefix from params - no-parameter-properties * Remove attribute value serialization at Span level (Serialization would happen in the default exporter) * Make isRecordingEvents=true for RealSpan * merge master * Add more tests * refactor: move real Span in basic-tracer package * chore: add codecov script * fix: add readonly * fix: store finishTime instread of duration * fix: rename _finishTime to _endTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.