opentelemetry.sdk.util type stubs #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9c6aa1 to
b34f968
Compare
ocelotl
approved these changes
Dec 11, 2020
NathanielRN
reviewed
Dec 16, 2020
NathanielRN
reviewed
Dec 16, 2020
| @@ -0,0 +1,71 @@ | |||
| # Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
Do imports for __init__.pyi files work?
There was a problem hiding this comment.
What do you mean? The pyi don't effect anything at runtime
There was a problem hiding this comment.
I meant the from typing import statements below, I was just curious what an import does in a .pyi file
NathanielRN
reviewed
Dec 16, 2020
| ] | ||
| Attributes = Optional[Mapping[str, AttributeValue]] | ||
| AttributesAsKey = Tuple[Tuple[str, AttributeValueAsKey], ...] |
There was a problem hiding this comment.
I looked up the Ellipsis here but I'm still unsure as to why it's needed here. If the key and value are already in the first element of the tuple, what goes in the rest of the tuple?
There was a problem hiding this comment.
NathanielRN
approved these changes
Dec 16, 2020
|
@aabmass looks like there's a few unresolved comments from @NathanielRN, can you take a quick look and resolve the conflict |
b34f968 to
8c19f08
Compare
lzchen
approved these changes
Jan 15, 2021
codeboten
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds type stubs for
opentelemetry/sdk/util/__init__py, most importantlyBoundedListandBoundedDictwhich are pretty widely used. I could not put the annotations inline because you can't subclasstyping.Sequenceandcollections.abc.Sequence, and you can't add generic parameters tocollections.abc.Sequenceeither.Type of change
How Has This Been Tested?
These are typing changes only, so I tested only by running mypy on this module
Checklist: