Add SpanKind option at span creation (closes #103). #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamim
suggested changes
Sep 16, 2019
Co-Authored-By: Aliaksei Urbanski <[email protected]>
Co-authored-by: Mauricio Vásquez <[email protected]>
lzchen
reviewed
Sep 17, 2019
| @@ -241,6 +241,7 @@ def __init__( | |||
| attributes: types.Attributes = None, # TODO | |||
| events: typing.Sequence[trace_api.Event] = None, # TODO | |||
| links: typing.Sequence[trace_api.Link] = None, # TODO | |||
| kind: trace_api.SpanKind = trace_api.SpanKind.INTERNAL, | |||
lzchen
approved these changes
Sep 17, 2019
carlosalberto
approved these changes
Sep 17, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* fix: add exported const of NoopSpan instance * fix: add INVALID_SPAN_CONTEXT as default value * fix: remove instance suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the Spec PR isn't merged and there's some discussion going on, I think this will be more useful than not being able to distinguish HTTP client & server at all.