-
Notifications
You must be signed in to change notification settings - Fork 778
Instrumentation Package depends on the OTel SDK #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation Package depends on the OTel SDK #1405
Conversation
dd4f7f0 to
6ec98a6
Compare
|
@owais Should be able to give a quick review since he has context! |
lzchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a direct contradiction to this?
|
@lzchen Yes I would agree that it contradicts that issue which has a valid point... However, the I can think of these options:
I think we should do 1 and then 2 as a quick follow up. If users really want 3 it shouldn't be hard to create a modification of the Please let me know what you think! Also cc @codeboten |
I agree with this. |
6ec98a6 to
3749d9c
Compare
|
do we need the SDK at all here? couldn't we use the entrypoints defined in |
|
The point about the I would stick by my point earlier that we don't really have to provide a 1 size fits all auto instrumentation solution. The example isn't too complicated, so I would imagine people could make their own auto instrumentation package if they really want to use another |
|
Closing this in favor of #1415 |
|
To unblock the release, i propose we merge this change and follow up with removing the dependency on the SDK in the next release |
3749d9c to
59728f8
Compare
|
Agreed, reopening this PR as a result of the conversion on gitter found here: https://gitter.im/open-telemetry/opentelemetry-python?at=5fbef0f82cb422778f3a1d9c |
afd89be to
033a015
Compare
033a015 to
fa676f8
Compare
|
Filed #1421 to track removing this dependency |
|
@lzchen please review the discussion and approve if you're ok with this plan moving of removing the dependency in the next release. |
Description
As a follow up to #1036, with the new configurability, the instrumentation package takes a dependency on
opentelemetry.sdkbecause of its use inopentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/components.pyType of change
Please delete options that are not relevant.
Checklist:
- [ ] Unit tests have been added- [] Documentation has been updated