Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update usage for Meter.create_counter in tests and examples, clean … #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 16, 2020
Merged

Update usage for Meter.create_counter in tests and examples, clean … #1463

merged 6 commits into from
Dec 16, 2020

Conversation

violalyu
Copy link
Contributor

@violalyu violalyu commented Dec 11, 2020 •
edited
Loading

…up unused imports

Description

Update usage for Meter.create_counter in tests and examples, clean up unused imports.

I was running the example provided for testing purposes, and noticed that there might be some usages of Meter.create_counter that was out of date.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I was running the same test as described in the README s for the examples.

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@violalyu violalyu requested review from a team, toumorokoshi and ocelotl and removed request for a team December 11, 2020 02:36
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 11, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

ocelotl
ocelotl suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please add a CHANGELOG entry 👍

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 11, 2020
lzchen
lzchen approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No user-facing changes. No need for a CHANGELOG. @ocelotl please dismiss request for change.

@ocelotl ocelotl self-requested a review December 11, 2020 16:27
ocelotl
ocelotl approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, @lzchen, approving then 👍

codeboten
codeboten approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeboten codeboten merged commit d8c3c24 into open-telemetry:master Dec 16, 2020
@violalyu violalyu deleted the create_counter_fix branch December 16, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@ocelotl ocelotl ocelotl approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@violalyu @codeboten @toumorokoshi @ocelotl @lzchen