Only comment on benchmarks on alert #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why will it always fail? |
a454b50 to
209afd7
Compare
@aabmass I was mistaken, I don't think that's the problem anymore, still trying to see why it fails after the
|
ef24d39 to
ea2eb43
Compare
d5aafa5 to
a14d64c
Compare
a14d64c to
66cdfb2
Compare
lzchen
approved these changes
Dec 14, 2020
aabmass
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #1473, the GitHub action would try to fetch thegh-pagesbranch using thesecrets.GITHUB_TOKENof the pull request author. This will always fail, so we should skip this step using the undocumentedskip-fetch-gh-pagesflag of the GitHub action we use. See source code that tries to pull gh-pagesWe narrowed the problem to the
comment-always: trueflag being set. And further, it only happens when multiple tests want to comment at the same time.To unblock the tests for now, we remove the feature which comments on the "new" benchmarks versus the "previous" benchmarks. We can come back and investigate later.
Example failed run: https://github.com/open-telemetry/opentelemetry-python/pull/1470/checks?check_run_id=1552050085#step:9:55
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
CI test should prove that this fix unblocks master tests.
Does This PR Require a Contrib Repo Change?
Checklist: