Make util a namespace #1582
Merged
Make util a namespace #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c23f3da to
bcf15a4
Compare
11 tasks
toumorokoshi
suggested changes
Feb 6, 2021
b3ed647 to
f840c31
Compare
11 tasks
codeboten
approved these changes
Feb 11, 2021
lzchen
approved these changes
Feb 11, 2021
|
I think it would be good to not skip the changelog and add an entry. |
|
@toumorokoshi |
Fixes open-telemetry#1581 This basically renames the __init__.py file in opentelemetry-api/util to make opentelemetry.util a proper namespace. This is needed since we are now adding components in the contrib repo in this namespace. More information here: https://packaging.python.org/guides/packaging-namespace-packages/#native-namespace-packages
toumorokoshi
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1581
This basically renames the init.py file in opentelemetry-api/util to
make opentelemetry.util a proper namespace. This is needed since we are
now adding components in the contrib repo in this namespace. More
information here:
https://packaging.python.org/guides/packaging-namespace-packages/#native-namespace-packages
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR: Update util path opentelemetry-python-contrib#319
No.
Checklist: