Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary warning when setting status description for non-error status #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lzchen merged 3 commits into from
Apr 2, 2021
Merged

Remove unnecessary warning when setting status description for non-error status #1721

lzchen merged 3 commits into from
Apr 2, 2021

Conversation

@owais
Copy link
Contributor

@owais owais commented Mar 28, 2021

Description

Currently we log a warning that status description should only be set
for an error condition even when description is not being set. This
commit silences such warnings.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@owais owais requested review from a team, srikanthccv and toumorokoshi and removed request for a team March 28, 2021 03:39
@owais
Remove unnecessary warning when (not) setting status description
dcc3c98 
Currently we log a warning that status description should only be set
for an error condition even when description is not being set. This
commit silences such warnings.
@owais owais force-pushed the fix-unnecessary-status-warning branch from 2a94455 to dcc3c98 Compare March 28, 2021 03:40
@owais owais changed the title Remove unnecessary warning when (not) setting status description Remove unnecessary warning when setting status description for non-error status Mar 30, 2021
@owais owais mentioned this pull request Apr 1, 2021
Closed
@lzchen lzchen merged commit 0c0466e into open-telemetry:main Apr 2, 2021
@owais owais deleted the fix-unnecessary-status-warning branch April 2, 2021 15:52
@lzchen lzchen mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

+3 more reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@owais @codeboten @toumorokoshi @lzchen @srikanthccv