Fix link to instrumentation #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current link points to 404. Following this open-telemetry#1797, the docs for instrumentation were moved to contrib
codeboten
approved these changes
May 7, 2021
lzchen
reviewed
May 10, 2021
docs/index.rst
Outdated
| @@ -34,7 +34,7 @@ In addition, there are several extension packages which can be installed separat | |||
| pip install opentelemetry-instrumentation-{instrumentation} | |||
|
|
|||
| These are for exporter and instrumentation packages respectively. | |||
| Some packages can be found in :scm_web:`instrumentation <instrumentation/>` and :scm_web:`exporter <exporter/>` | |||
| Some packages can be found in `instrumentation <https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation>`_ and :scm_web:`exporter <exporter/>` | |||
There was a problem hiding this comment.
We actually shouldn't even have this part since all of the instrumentations exist in the contrib repo.
There was a problem hiding this comment.
@marcosflobo do you want to modify this PR to remove this line instead?
There was a problem hiding this comment.
@ocelotl I can see that @codeboten updated the line. You tell me if you want me to remove the line or keep the last changes from @codeboten
|
Updated the text, please take a look @lzchen |
lzchen
reviewed
May 26, 2021
lzchen
approved these changes
May 26, 2021
|
@ocelotl please take a look at @marcosflobo's last comment. |
Co-authored-by: Leighton Chen <[email protected]>
ocelotl
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link points to 404. Following this #1797, the docs for instrumentation were moved to contrib
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: