Update SDK time precision warning to reference correct PEP #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct typo to reference the PIP that talks about nanosecond precision in python: https://www.python.org/dev/peps/pep-0564/
srikanthccv
approved these changes
May 23, 2021
owais
approved these changes
May 24, 2021
lzchen
approved these changes
May 24, 2021
codeboten
approved these changes
May 25, 2021
|
Hey @jlisee, please take a look and sign the CLA to get this PR merged, thanks! |
I signed it as the email attached to this commit so we should be good to go. Thanks for the patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When developing on Python older than 3.7 a warning is logged about timing
precision, this fixes that warning to reference PEP 564. This is the PEP
that talks about nanosecond precision in python:
https://www.python.org/dev/peps/pep-0564/
Type of change
How Has This Been Tested?
The above link has been read and verified it refers to time precision instead of
backporting SSL memory to Python 2.7 (PEP 546).
Checklist: