remove dependency on contrib repo to run tox #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c853e6 to
632bfc9
Compare
owais
approved these changes
Sep 13, 2021
srikanthccv
approved these changes
Sep 13, 2021
ocelotl
approved these changes
Sep 14, 2021
lzchen
approved these changes
Sep 14, 2021
Added a note @lonewolf3739, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than cloning the contrib repo, tox now installs the packages directly from the contrib repository in github. It uses the env variable
CONTRIB_REPO_SHAto determine what commit to use when installing the packages. It defaults tomainunless specified. In the CI, that env variable is set, so we should be good to go.This is a followup to #2105, will rebase once that's merged.