add note about proto version to README.rst #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
approved these changes
Oct 21, 2021
owais
approved these changes
Oct 21, 2021
aabmass
added a commit
that referenced
this pull request
Oct 29, 2021
* updating changelogs and version to 1.6.1-0.25b1 (#2223) * default value is invalid, was renamed (#2226) * Website: support GH page links to canonical src, and aliases (#2224) * Fix opentracing shim references (#2180) * Prepare release v1.6.2 and 0.25b2 (#2230) * update changelog to note the rename of entrypoints in 1.6.0 (#2228) * add note about proto version to README.rst (#2232) * ReadableSpan events and links now return a tuple (#2215) * ReadableSpan events and links now return a tuple Removed MappingProxy since events and links are not mappings Signed-off-by: Ted Kern <[email protected]> * fix lint Signed-off-by: Ted Kern <[email protected]> * fix lint * fix lint Co-authored-by: Diego Hurtado <[email protected]> Co-authored-by: Leighton Chen <[email protected]> * adding CI testing for python 3.10 (#2207) * remove `X-B3-ParentSpanId` for B3 propagator as per OpenTelemetry Specification (#2237) * remove X-B3-ParentSpanId for B3 propagator as per OpenTelemetry specification * revert changes - run tests * re-commit changes * add entry to CHANGELOG * remove ParentSpanId in B3SingleFormat * Remove lingering distro pkg files (#2241) Co-authored-by: Leighton Chen <[email protected]> Co-authored-by: alrex <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Ben Roberts <[email protected]> Co-authored-by: Owais Lone <[email protected]> Co-authored-by: Ted Kern <[email protected]> Co-authored-by: Diego Hurtado <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a note to the
opentelemetry-protoreadme file about the proto version used in the package. also added a note to the proto generation script to remind its caller to update this document.Fixes #2222