Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add periodic exporting metric reader #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 21, 2022
Merged

Add periodic exporting metric reader #2340

merged 22 commits into from
Jan 21, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Dec 19, 2021 •
edited by codeboten
Loading

Description

Fixes #2332
Fixes #2295

codeboten
codeboten reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lonewolf3739 is this still work in progress? I think this is the last piece needed to have an end-to-end pipeline for producing metrics.

@srikanthccv
Copy link
Member Author

@codeboten I need to fix up the tests and some trivial clean up. I will push out the changes soon.

@srikanthccv srikanthccv added Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 19, 2022
@srikanthccv srikanthccv marked this pull request as ready for review January 19, 2022 00:11
@srikanthccv srikanthccv requested review from a team, lzchen, ocelotl and aabmass January 19, 2022 00:11
codeboten
codeboten reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise the code and tests look great, thanks @lonewolf3739!

ocelotl
ocelotl suggested changes Jan 19, 2022
View reviewed changes
aabmass
aabmass reviewed Jan 19, 2022
View reviewed changes
@srikanthccv srikanthccv requested a review from aabmass January 19, 2022 23:14
aabmass
aabmass reviewed Jan 21, 2022
View reviewed changes
aabmass
aabmass approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more nits/optional comments

LGTM!

@ocelotl ocelotl enabled auto-merge (squash) January 21, 2022 16:15
@ocelotl ocelotl merged commit 83e6e17 into open-telemetry:main Jan 21, 2022
@srikanthccv srikanthccv deleted the issue-2332 branch January 21, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

@lzchen lzchen Awaiting requested review from lzchen

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PeriodicExportingMetricReader Add MetricReader
4 participants
@srikanthccv @codeboten @aabmass @ocelotl