Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introducing and documenting the concept of OTel buddies. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

toumorokoshi
Copy link
Member

No description provided.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the "OTel" name, looks good otherwise!

CONTRIBUTING.md Outdated
2. Post in the room with an introduction to yourself, what area you are interested in, and say you are looking for a buddy. We will match you with
someone who has experience in that area.

Your OTel buddy is your resource to talk to directly on all aspects of contributing to OpenTelemetry: providing context, reviewing PRs, and helping those get merged. Buddies will not be available 24/7, but is committed to responding during their normal contribution hours.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your OTel buddy is your resource to talk to directly on all aspects of contributing to OpenTelemetry: providing context, reviewing PRs, and helping those get merged. Buddies will not be available 24/7, but is committed to responding during their normal contribution hours.
Your OpenTelemetry buddy is your resource to talk to directly on all aspects of contributing to OpenTelemetry: providing context, reviewing PRs, and helping those get merged. Buddies will not be available 24/7, but is committed to responding during their normal contribution hours.

IIRC we are specifically not supposed to call this OTel.

And how come this line doesn't get wrapped but the others do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the line wrapping at the same time. Do you know why we're not supposed to call things "OTel"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably because of https://www.otel.com.

CONTRIBUTING.md Outdated
for your first contribution, join our Gitter and find a buddy!

1. Join [Gitter.im](https://gitter.im) and join our [chat room](https://gitter.im/open-telemetry/opentelemetry-python).
2. Post in the room with an introduction to yourself, what area you are interested in, and say you are looking for a buddy. We will match you with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention issues marked as "Help wanted" to start with if there is any available

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could always use more buddies! :D

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the line wrapping.

CONTRIBUTING.md Outdated
@@ -13,6 +13,17 @@ on how to become a [**Member**](https://github.com/open-telemetry/community/blob
[**Approver**](https://github.com/open-telemetry/community/blob/master/community-membership.md#approver)
and [**Maintainer**](https://github.com/open-telemetry/community/blob/master/community-membership.md#maintainer).

## Find an OTel Buddy and Get Started Quickly!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Find an OTel Buddy and Get Started Quickly!
## Find a Buddy and Get Started Quickly!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tongue in cheek trying to get a brand on OpenTelemetry buddies :) but I'll fix it up.

@Oberon00
Copy link
Member

We should also bring this up in the community meeting/repository, it sounds useful and is not Python-specific.

@toumorokoshi toumorokoshi merged commit dba806f into open-telemetry:master Oct 28, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
* feat(plugin): add supportedVersions property

Closes open-telemetry#132

Signed-off-by: Olivier Albertini <[email protected]>

* fix: add recommendations

from markwolff
from mayurkale22

Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants