Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement to_json for Metric #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2022
Merged

implement to_json for Metric #2475

merged 4 commits into from
Feb 22, 2022

Conversation

codeboten
Copy link
Contributor

Implementing the to_json method for Metric to be used with the ConsoleMetricExporter.

implement to_json for Metric
07f187d 
Implementing the to_json method for Metric to be used with the ConsoleMetricExporter.
@codeboten codeboten requested a review from a team February 18, 2022 18:13
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 18, 2022
srikanthccv
srikanthccv reviewed Feb 19, 2022
View reviewed changes
codeboten
codeboten commented Feb 20, 2022
View reviewed changes
Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added unit test for this change, please review.

@lzchen lzchen merged commit 672c449 into open-telemetry:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @lzchen @srikanthccv