Add drop aggregation #2544
Merged
Add drop aggregation #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intentionally implemented this as a regular aggregation to avoid not creating |
aabmass
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
@ocelot I see what you mean about the default being created. We could also add a boolean to check if a view matched instead of checking for empty array?
I'm ok with this for now and we can address it later as an optimization.
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Abbott <[email protected]>
7 tasks
|
@ocelotl it would be good to start updating the changelog now that we have an experimental release I think |
lzchen
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2536