Fix typo in example #2597
Merged
Fix typo in example #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
approved these changes
Apr 12, 2022
srikanthccv
approved these changes
Apr 12, 2022
ocelotl
pushed a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Apr 12, 2022
ocelotl
added a commit
that referenced
this pull request
Apr 12, 2022
* Add check for duplicate instrument names Fixes #2142 * Add repeated instrument names for SDK as well * Update opentelemetry-api/src/opentelemetry/_metrics/__init__.py Co-authored-by: Srikanth Chekuri <[email protected]> * Add instrument names lock * Replace raised exception for a warning * Added some fiexes * Add double check * Add type annotations * Update opentelemetry-api/src/opentelemetry/_metrics/__init__.py Co-authored-by: Srikanth Chekuri <[email protected]> * Move check invocation to SDK * Fix lint * Separate instrument checking from warning logging * Use consistent class * Fix typo in example (#2597) * Fix docs Co-authored-by: Srikanth Chekuri <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement PR for #2472