Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Decentralizing the Python members #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Nov 4, 2019

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the change LGTM, but the top of the main README seems like the wrong place for this, and makes it difficult to read. What about putting this in CONTRIBUTORS?

README.md Outdated
@@ -4,6 +4,24 @@
[gitter-image]: https://badges.gitter.im/open-telemetry/opentelemetry-python.svg
[gitter-url]: https://gitter.im/open-telemetry/opentelemetry-python?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge

We hold regular meetings. See details at [community page](https://github.com/open-telemetry/community#python-sdk).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we could move this out of the community repo too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, shouldn't that be "python SIG" instead of "python SDK"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, but "SDK" had a different meaning when that doc was first written. We can fix that here by just moving the content into this doc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I go back and forth. It's a little nice to see all the meetings in one list. It's not always evident what meetings do or do not occur.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @toumorokoshi. I like seeing a list of all meetings and details in one place. With that being said, we can change python-sdk to python-sig in the community repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put it in both places. It seems a bit ridiculous to direct people to the community repo when we could just say "every thursday at 8AM PT" here.

open-telemetry/community#233 also says we ought to move the meeting schedule here:

Similarly, the SIG information (schedule of meetings, etc.) can be also moved from the README in this repo to the READMEs in the respective repos. This repo will only have the links to information.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

README.md Outdated
@@ -4,6 +4,24 @@
[gitter-image]: https://badges.gitter.im/open-telemetry/opentelemetry-python.svg
[gitter-url]: https://gitter.im/open-telemetry/opentelemetry-python?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge

We hold regular meetings. See details at [community page](https://github.com/open-telemetry/community#python-sdk).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I go back and forth. It's a little nice to see all the meetings in one list. It's not always evident what meetings do or do not occur.

@lzchen
Copy link
Contributor Author

lzchen commented Nov 5, 2019

@c24t The javascript and .NET repositories both have this information in their READMEs. I feel like it's good to be consistent. With that being said, you're right about the awkward placement at the top of the repo. I'll put this in the "contributing" section in the README just like what js is doing.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm in favor of moving most repo-specific content out of community, but this is a big improvement even as-is.

The comment is a suggestion, feel free to disregard it or save the changes for another PR.

README.md Outdated
@@ -77,6 +77,24 @@ for a complete example.

See [CONTRIBUTING.md](CONTRIBUTING.md)

We hold regular meetings. See details at [community page](https://github.com/open-telemetry/community#python-sdk).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I would write here to replace the content on the community page:


We meet weekly on Thursday at 8AM PT. The meeting is subject to change depending on contributors' availability. Check the OpenTelemetry community calendar for specific dates.

Meetings take place via Zoom video conference: https://zoom.us/j/6729396170.

Meeting notes are available as a public Google doc. For edit access, get in touch on Gitter.

@c24t c24t merged commit f510215 into open-telemetry:master Nov 7, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants