add pypi badges and installation instructions to all ext packages #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't update the azure exporter because it's going to be removed from this repo.
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
======================================
Coverage 85.5% 85.5%
======================================
Files 33 33
Lines 1608 1608
Branches 181 181
======================================
Hits 1375 1375
Misses 186 186
Partials 47 47Continue to review full report at Codecov.
|
codeboten
reviewed
Nov 8, 2019
| @@ -1,9 +1,20 @@ | |||
| OpenTelemetry WSGI Middleware | |||
| ============================= | |||
|
|
|||
| .. |pypi| image:: https://badge.fury.io/py/opentelemetry-opentracing-wsgi.svg | |||
There was a problem hiding this comment.
This one doesn't render. Missing a [pypi] above?
There was a problem hiding this comment.
You're right, thanks!
c24t
approved these changes
Nov 9, 2019
| [gitter-url]: https://gitter.im/open-telemetry/opentelemetry-python?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge | ||
| [](https://travis-ci.org/open-telemetry/opentelemetry-python) | ||
| [](https://gitter.im/open-telemetry/opentelemetry-python) | ||
| [](https://travis-ci.org/open-telemetry/opentelemetry-python) |
fix "typo" Co-Authored-By: Chris Kleinknecht <[email protected]>
Oberon00
approved these changes
Nov 11, 2019
| @@ -1,9 +1,22 @@ | |||
| OpenTelemetry WSGI Middleware | |||
| ============================= | |||
|
|
|||
| |pypi| | |||
|
|
|||
| .. |pypi| image:: https://badge.fury.io/py/opentelemetry-wsgi.svg | |||
There was a problem hiding this comment.
Can't we just use image:: without the |pypi| stuff?
There was a problem hiding this comment.
I think this syntax is more readable when there are many badges, for instance:
|GitterChat| |BuildStatus| |PyPI| |ReadTheDocs|
hectorhdzg
reviewed
Nov 11, 2019
| .. |pypi| image:: https://badge.fury.io/py/opentelemetry-ext-jaeger.svg | ||
| :target: https://pypi.org/project/opentelemetry-ext-jaeger/ | ||
|
|
||
|
|
There was a problem hiding this comment.
Having a small description of the package would be great, similar to other readme files
hectorhdzg
approved these changes
Nov 11, 2019
…emetry-python into mauricio/improve_readmes
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…metry#281) * feat: add hrTimeToMicroeconds and fix numberToHrtime func * fix: build * fix: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cosmetic change.