Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove [test] package from opentelemetry-exporter-otlp-proto-grpc #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Mar 2, 2024

Fixes #3724

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 2, 2024
@ocelotl ocelotl self-assigned this Mar 2, 2024
@ocelotl ocelotl requested a review from a team March 2, 2024 01:26
@ocelotl ocelotl force-pushed the issue_3724 branch 4 times, most recently from cdee961 to a33d975 Compare March 8, 2024 05:30
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 21, 2024

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

@ocelotl ocelotl marked this pull request as draft March 21, 2024 01:13
@emdneto
Copy link
Member

emdneto commented Apr 4, 2024

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

@ocelotl
In line 128 I think there is an invisible character at the beginning

grep "$(printf '\xEF\xBF\xBC')" tox.ini

matches:

proto4-opentelemetry-exporter-otlp-proto-grpc: pip install -r {toxinidir}/exporter/opentelemetry-exporter-otlp-proto-grpc/test-requirements-1.txt

For me, removing the invisible character I was able to run tox -rvvve py38-proto4-opentelemetry-exporter-otlp-proto-grpc

@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 12, 2024

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

@ocelotl In line 128 I think there is an invisible character at the beginning

grep "$(printf '\xEF\xBF\xBC')" tox.ini

matches:

proto4-opentelemetry-exporter-otlp-proto-grpc: pip install -r {toxinidir}/exporter/opentelemetry-exporter-otlp-proto-grpc/test-requirements-1.txt

For me, removing the invisible character I was able to run tox -rvvve py38-proto4-opentelemetry-exporter-otlp-proto-grpc

Whoah. This is incredible. I was totally out of answers. Thanks a lot @emdneto!

@ocelotl ocelotl marked this pull request as ready for review April 12, 2024 20:41
@ocelotl ocelotl merged commit 9866842 into open-telemetry:main Apr 12, 2024
@ocelotl ocelotl deleted the issue_3724 branch April 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove [test] package from opentelemetry-exporter-otlp-proto-grpc
3 participants