Thanks to visit codestin.com
Credit goes to github.com

Skip to content

changed typing.Dict to typing.Mapping #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

soumyadeepm04
Copy link
Contributor

Description

changed typing.Dict to typing.Mapping to fix mypy warning.

Fixes #3696

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tested locally and mypy in tox runs without issues.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@soumyadeepm04 soumyadeepm04 requested a review from a team June 21, 2024 19:05
@soumyadeepm04 soumyadeepm04 marked this pull request as draft June 21, 2024 19:09
@soumyadeepm04 soumyadeepm04 marked this pull request as ready for review June 21, 2024 19:17
@soumyadeepm04
Copy link
Contributor Author

the public-symbols-check passes locally but doesn't pass here (I don't create any public symbols). Could someone help with what the reason could be?

@xrmx xrmx added Skip Changelog PRs that do not require a CHANGELOG.md entry Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Jun 21, 2024
@xrmx xrmx removed the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jun 21, 2024
@lzchen lzchen merged commit 857e7ef into open-telemetry:main Jun 24, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy warns about passing dictionaries as variables to opentelemetry.sdk.resources.Resource.create
4 participants