Add fallback handling for encode log body #4601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ouyuran I think current code already handles this at a layer before the exporter. |
|
@xrmx thanks for the info, I just checked release notes, it has been fixed at 1.32.0 which is one minor version ahead of us. I'll test on the new version. |
|
@ouyuran had a chance to test a newer sdk? |
|
@xrmx sorry for late, yes, I've tested on 1.33.1. It works as expected. I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a fallback handling for log body encoding, if it cannot be handled by
_encode_valuethen it will be converted to string by callingstrfirst.Fixes #4100
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: