Use SDK providers in example code #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=======================================
Coverage 89.19% 89.20%
=======================================
Files 43 43
Lines 2175 2177 +2
Branches 243 243
=======================================
+ Hits 1940 1942 +2
Misses 165 165
Partials 70 70
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-python/pull/466/files#r392613438.
This PR updates docs and example code to use SDK-provided providers following #466.
#466 removed
set_preferred_implementationin favor ofset_providermethods. Before this change, most example code and docs loaded the SDKTracerProviderandMeterProvider. Although we technically don't need these lines now that it's possible to set the default providers in config, I think it's still useful to include them since we expect most users to use the SDK types. Writing the examples this way means they can run as-is without a separate config file.cc @ocelotl.