Docs / Examples Update for get_tracer_provider()
#503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_tracer_provider()` rather than `tracer_provider()`
`.get_tracer_provider()` instead of `.tracer_provider()`
`.get_tracer_provider()` instead of `.tracer_provider()`
|
Would you mind fixing this as well? |
`.get_meter_provider()` rather than `.meter_provider()`
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 43 43
Lines 2213 2213
Branches 249 249
=======================================
Hits 1982 1982
Misses 159 159
Partials 72 72
Continue to review full report at Codecov.
|
codeboten
suggested changes
Mar 18, 2020
There was a problem hiding this comment.
Thanks for taking this on @disfluxly! There's a few more references that need updating:
|
@codeboten I updated the missing examples, @lzchen @hectorhdzg would you mind guys having a look at the changes on the DB integrations? |
|
@mauriciovasquezbernal - Thanks! Things got a little hectic over here so didn't see this until now :) |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat(plugin): implement redis plugin * fix: circle redis testing * fix: set span error status * fix: run the redis service * fix: linting * feat: add redis error handling statuses * fix: pr comments * fix: redis linting * refactor: move patches to utils for clarity * fix: linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the zipkin/jaeger ext READMEs and also a small doc update.
0.5.0 changed
.tracer_provider()to.get_tracer_provider()opentelemetry-python/opentelemetry-api/src/opentelemetry/trace/__init__.py
Line 669 in f52468b