Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add pip caching to Travis CI builds #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

Add pip caching to Travis CI builds #520

merged 2 commits into from
Mar 23, 2020

Conversation

dgzlopes
Copy link
Contributor

Caches lets Travis CI store directories between builds, which is useful for storing dependencies that take longer to compile or download. -Travis CI Docs

PR adds pip caching to the .travis.yml
This could be helpful for #513

Signed-off-by: Daniel GonzΓ‘lez Lopes [email protected]

@dgzlopes dgzlopes requested a review from a team March 22, 2020 10:20
@dgzlopes
Add caching for pip files
6443ca0 
Signed-off-by: Daniel GonzΓ‘lez Lopes <[email protected]>

Clean build file

Signed-off-by: Daniel GonzΓ‘lez Lopes <[email protected]>
@codecov-io
Copy link

codecov-io commented Mar 22, 2020 •
edited
Loading

Codecov Report

Merging #520 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   89.47%   89.37%   -0.10%     
==========================================
  Files          43       43              
  Lines        2213     2193      -20     
  Branches      250      250              
==========================================
- Hits         1980     1960      -20     
  Misses        161      161              
  Partials       72       72
Impacted Files Coverage Ξ”
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 67.56% <0.00%> (-0.58%) ⬇️
...lemetry-sdk/src/opentelemetry/sdk/util/__init__.py 85.54% <0.00%> (-0.35%) ⬇️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.18% <0.00%> (-0.29%) ⬇️
...src/opentelemetry/ext/opentracing_shim/__init__.py 95.86% <0.00%> (-0.17%) ⬇️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 86.39% <0.00%> (-0.16%) ⬇️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 92.46% <0.00%> (-0.06%) ⬇️
...etry-sdk/src/opentelemetry/sdk/metrics/__init__.py 94.84% <0.00%> (-0.03%) ⬇️
.../src/opentelemetry/sdk/metrics/export/aggregate.py 100.00% <0.00%> (ΓΈ)
...app/src/opentelemetry_example_app/flask_example.py 100.00% <0.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 8aa58fb...6443ca0. Read the comment docs.

toumorokoshi
toumorokoshi approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! do you have benchmarks around the improvement?

I'm doing a spot check on this build vs other branches, and I see ~ 1 minute improvement in the python3.8 task:

https://travis-ci.org/github/open-telemetry/opentelemetry-python/builds/665436900?utm_source=github_status&utm_medium=notification (39m total time)
https://travis-ci.org/github/open-telemetry/opentelemetry-python/builds/664957298?utm_medium=notification&utm_source=github_status (41m total time)

@toumorokoshi
Copy link
Member

@c24t this might interest you :)

@dgzlopes
Copy link
Contributor Author

dgzlopes commented Mar 23, 2020 •
edited
Loading

Hi @toumorokoshi, thank you for taking the time to review :)

I have these builds from my fork:
(1 - Total time 43 min 57 sec) -- https://travis-ci.com/github/dgzlopes/opentelemetry-python/builds/154464390
(2 - Total time 33 min 36 sec) -- https://travis-ci.com/github/dgzlopes/opentelemetry-python/builds/154636971

The second build uses the cache created by the first one.

@Oberon00
Copy link
Member

These build times are still a good reason to google how to spell "abysmal". πŸ˜„

@c24t
Copy link
Member

c24t commented Mar 23, 2020

Very relevant to my interests, thanks for picking this up @dgzlopes!

The change LGTM, but I'm surprised it's such a small improvement. Looks like there's still work to do to speed our builds up.

@toumorokoshi toumorokoshi merged commit fbfafa4 into open-telemetry:master Mar 23, 2020
@toumorokoshi
Copy link
Member

thanks!

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22 @bg451
chore: fix codecov path (open-telemetry#520)
36496f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgzlopes @codecov-io @toumorokoshi @Oberon00 @c24t